hlteoh37 commented on code in PR #165:
URL:
https://github.com/apache/flink-connector-aws/pull/165#discussion_r1765101564
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/config/KinesisSourceConfigOptions.java:
##########
@@ -19,12 +19,17 @@
package org.apache.flink.connector.kinesis.source.config;
import org.apache.flink.annotation.Experimental;
+import org.apache.flink.annotation.PublicEvolving;
import org.apache.flink.configuration.ConfigOption;
import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.connector.aws.config.AWSConfigOptions;
+
+import java.time.Duration;
/** Constants to be used with the KinesisStreamsSource. */
@Experimental
-public class KinesisStreamsSourceConfigConstants {
+@PublicEvolving
Review Comment:
Hmmm, there's no point having both here - Only 1 is required. Because this
connector is still `@Experimental` we can keep it that way 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
