yuxiqian commented on code in PR #3608:
URL: https://github.com/apache/flink-cdc/pull/3608#discussion_r1766088822
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlPipelineITCase.java:
##########
@@ -61,11 +62,7 @@
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.Iterator;
-import java.util.List;
+import java.util.*;
Review Comment:
This will be rejected by Spotless check
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSource.java:
##########
@@ -45,7 +45,9 @@ public MySqlDataSource(MySqlSourceConfigFactory
configFactory) {
public EventSourceProvider getEventSourceProvider() {
MySqlEventDeserializer deserializer =
new MySqlEventDeserializer(
- DebeziumChangelogMode.ALL,
sourceConfig.isIncludeSchemaChanges());
+ DebeziumChangelogMode.ALL,
+ sourceConfig.isIncludeSchemaChanges(),
+ sourceConfig.getJdbcProperties());
Review Comment:
I'm thinking if we need to pass the whole `JdbcProperties` into the
deserializer, since `tinyInt1isBit` is the only key that relevant to type
deserialization. Maybe passing a `boolean tinyInt1isBit` is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
