1996fanrui commented on PR #25218:
URL: https://github.com/apache/flink/pull/25218#issuecomment-2367911956
Hi @XComp , thank you for the quick review and feedback.
> I'm not sure about adding this feature to the StateLocalitySlotAssigner.
Shouldn't state locality have priority over task count per TM?
Great point! It's the main reason why I cc you help double check this PR.
- The state locality only take effect during the job recovery, it's an
optimization.
- If StateLocalitySlotAssigner doesn't consider this logic, flink job will
waste some resources.
- For example, 60 Tasksmanagers is enough, but flink is using the 100
Tasksmanagers.
- It's more like a bug.
IMHO, the bug has higher priority than an optimization.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
