hlteoh37 commented on code in PR #170:
URL:
https://github.com/apache/flink-connector-aws/pull/170#discussion_r1772950453
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java:
##########
@@ -254,31 +252,10 @@ private RetryStrategy createExpBackoffRetryStrategy(
final BackoffStrategy backoffStrategy =
BackoffStrategy.exponentialDelayHalfJitter(initialDelay,
maxDelay);
- return StandardRetryStrategy.builder()
+ return SdkDefaultRetryStrategy.standardRetryStrategyBuilder()
Review Comment:
> Do we have any thoughts on how this would work with a user defined
retryable exceptions improvement like the one in the old connector?
Good qn - we can add more predicates by calling `retryOnException()`, but we
won't be able to override the ones already marked as non-retryable in the SDK
defaults, because I think it does eager checks for non-retryable errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
