snuyanzin commented on code in PR #25388:
URL: https://github.com/apache/flink/pull/25388#discussion_r1774883976
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala:
##########
@@ -439,17 +439,16 @@ object FlinkRexUtil {
})
private class EquivalentExprShuttle(rexBuilder: RexBuilder) extends
RexShuttle {
- private val equiExprMap = mutable.HashMap[String, RexNode]()
+ private val equiExprSet = mutable.HashSet[RexNode]()
override def visitCall(call: RexCall): RexNode = {
call.getOperator match {
case EQUALS | NOT_EQUALS | GREATER_THAN | LESS_THAN |
GREATER_THAN_OR_EQUAL |
LESS_THAN_OR_EQUAL =>
- val swapped = swapOperands(call)
- if (equiExprMap.contains(swapped.toString)) {
- swapped
+ if (equiExprSet.contains(call)) {
Review Comment:
jira issue https://issues.apache.org/jira/browse/FLINK-36367
I tried
1. it touches more than 100 plans which is still doable
2. I faced one float issue for a couple of plans: depending on how tests are
running (just one or for the whole class) the order of operands is different
(the operator expression is valid for both).
So need more time to debug and fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
