liuyongvs commented on code in PR #25380:
URL: https://github.com/apache/flink/pull/25380#discussion_r1774775646
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/TemporalJoinRewriteWithUniqueKeyRule.java:
##########
@@ -57,8 +57,8 @@
* a table source or a view only if it contains the unique key and time
attribute.
*
* <p>Flink supports extract the primary key and row time attribute from the
view if the view comes
- * from {@link StreamPhysicalRank} node which can convert to a {@link
StreamPhysicalDeduplicate}
- * node.
+ * from {@link StreamPhysicalRank} node which can convert to a {@link
StreamExecDeduplicate}
+ * finally. node.
Review Comment:
finally. node. -> node finally.
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/physical/stream/ChangelogModeInferenceTest.xml:
##########
@@ -321,7 +321,7 @@ Calc(select=[amount, currency, rowtime,
PROCTIME_MATERIALIZE(proctime) AS procti
: +- Calc(select=[amount, currency, rowtime, PROCTIME() AS proctime],
changelogMode=[I])
: +- LegacyTableSourceScan(table=[[default_catalog,
default_database, Orders, source: [CollectionTableSource(amount, currency,
rowtime)]]], fields=[amount, currency, rowtime], changelogMode=[I])
Review Comment:
the physical plan looks good to me and the exec plan is not changed +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
