[
https://issues.apache.org/jira/browse/FLINK-35574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884942#comment-17884942
]
Yue Ma commented on FLINK-35574:
--------------------------------
[~Zakelly] can you help mark this ticket as Resolved ?
> Setup base branch for FrocksDB-8.10
> -----------------------------------
>
> Key: FLINK-35574
> URL: https://issues.apache.org/jira/browse/FLINK-35574
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / State Backends
> Affects Versions: 2.0.0
> Reporter: Yue Ma
> Assignee: Yue Ma
> Priority: Major
> Fix For: 2.0.0
>
>
> As the first part of FLINK-35573, we need to prepare a base branch for
> FRocksDB-8.10.0 first. Mainly, it needs to be checked out from version 8.10.0
> of the Rocksdb community. Then check pick the commit which used by Flink from
> FRocksDB-6.20.3 to 8.10.0
> *Details:*
> |*JIRA*|*FrocksDB-6.20.3*|*Commit ID in FrocksDB-8.10.0*|*Plan*|
> |[[FLINK-10471] Add Apache Flink specific compaction filter to evict expired
> state which has
> time-to-live|https://github.com/ververica/frocksdb/commit/3da8249d50c8a3a6ea229f43890d37e098372786]|3da8249d50c8a3a6ea229f43890d37e098372786|d606c9450bef7d2a22c794f406d7940d9d2f29a4|Already
> in *FrocksDB-8.10.0*|
> |+[[FLINK-19710] Revert implementation of PerfContext back to __thread to
> avoid performance
> regression|https://github.com/ververica/frocksdb/commit/d6f50f33064f1d24480dfb3c586a7bd7a7dbac01]+|d6f50f33064f1d24480dfb3c586a7bd7a7dbac01|
> |Fix in FLINK-35575|
> |[FRocksDB release guide and helping
> scripts|https://github.com/ververica/frocksdb/commit/2673de8e5460af8d23c0c7e1fb0c3258ea283419]|2673de8e5460af8d23c0c7e1fb0c3258ea283419|b58ba05a380d9bf0c223bc707f14897ce392ce1b|Already
> in *FrocksDB-8.10.0*|
> |+[Add content related to ARM building in the FROCKSDB-RELEASE
> documentation|https://github.com/ververica/frocksdb/commit/ec27ca01db5ff579dd7db1f70cf3a4677b63d589]+|ec27ca01db5ff579dd7db1f70cf3a4677b63d589|6cae002662a45131a0cd90dd84f5d3d3cb958713|Already
> in *FrocksDB-8.10.0*|
> |[[FLINK-23756] Update FrocksDB release document with more
> info|https://github.com/ververica/frocksdb/commit/f75e983045f4b64958dc0e93e8b94a7cfd7663be]|f75e983045f4b64958dc0e93e8b94a7cfd7663be|bac6aeb6e012e19d9d5e3a5ee22b84c1e4a1559c|Already
> in *FrocksDB-8.10.0*|
> |[Add support for Apple Silicon to RocksJava
> (#9254)|https://github.com/ververica/frocksdb/commit/dac2c60bc31b596f445d769929abed292878cac1]|dac2c60bc31b596f445d769929abed292878cac1|#9254|Already
> in *FrocksDB-8.10.0*|
> |[Fix RocksJava releases for macOS
> (#9662)|https://github.com/ververica/frocksdb/commit/22637e11968a627a06a3ac8aa78126e3ae6d1368]|22637e11968a627a06a3ac8aa78126e3ae6d1368|#9662|Already
> in *FrocksDB-8.10.0*|
> |+[Fix clang13 build error
> (#9374)|https://github.com/ververica/frocksdb/commit/a20fb9fa96af7b18015754cf44463e22fc123222]+|a20fb9fa96af7b18015754cf44463e22fc123222|#9374|Already
> in *FrocksDB-8.10.0*|
> |+[[hotfix] Resolve brken make
> format|https://github.com/ververica/frocksdb/commit/cf0acdc08fb1b8397ef29f3b7dc7e0400107555e]+|7a87e0bf4d59cc48f40ce69cf7b82237c5e8170c|
> |Already in *FrocksDB-8.10.0*|
> |+[Update circleci xcode version
> (#9405)|https://github.com/ververica/frocksdb/commit/f24393bdc8d44b79a9be7a58044e5fd01cf50df7]+|cf0acdc08fb1b8397ef29f3b7dc7e0400107555e|#9405|Already
> in *FrocksDB-8.10.0*|
> |+[Upgrade to Ubuntu 20.04 in our CircleCI
> config|https://github.com/ververica/frocksdb/commit/1fecfda040745fc508a0ea0bcbb98c970f89ee3e]+|1fecfda040745fc508a0ea0bcbb98c970f89ee3e|
> |Fix in
> [FLINK-35577|https://github.com/facebook/rocksdb/pull/9481/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47]
> fixed in
> https://github.com/facebook/rocksdb/pull/9481/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47|
> |[Disable useless broken tests due to ci-image
> upgraded|https://github.com/ververica/frocksdb/commit/9fef987e988c53a33b7807b85a56305bd9dede81]|9fef987e988c53a33b7807b85a56305bd9dede81|
> |Fix in FLINK-35577|
> |[[hotfix] Use zlib's fossils page to replace
> web.archive|https://github.com/ververica/frocksdb/commit/cbc35db93f312f54b49804177ca11dea44b4d98e]|cbc35db93f312f54b49804177ca11dea44b4d98e|8fff7bb9947f9036021f99e3463c9657e80b71ae|Already
> in *FrocksDB-8.10.0*|
> |+[[hotfix] Change the resource request when running
> CI|https://github.com/ververica/frocksdb/commit/2ec1019fd0433cb8ea5365b58faa2262ea0014e9]+|2ec1019fd0433cb8ea5365b58faa2262ea0014e9|174639cf1e6080a8f8f37aec132b3a500428f913|Already
> in *FrocksDB-8.10.0*|
> |{+}[[FLINK-30321] Upgrade ZLIB of FRocksDB to 1.2.13
> (|https://github.com/ververica/frocksdb/commit/3eac409606fcd9ce44a4bf7686db29c06c205039]{+}[#56|https://github.com/ververica/frocksdb/pull/56]
>
> [)|https://github.com/ververica/frocksdb/commit/3eac409606fcd9ce44a4bf7686db29c06c205039]|3eac409606fcd9ce44a4bf7686db29c06c205039|
> |*FrocksDB-8.10.0 has upgrade to 1.3*|
> |[fix(CompactionFilter): avoid expensive ToString call when not in
> Debug`|https://github.com/ververica/frocksdb/commit/698c9ca2c419c72145a2e6f5282a7860225b27a0]|698c9ca2c419c72145a2e6f5282a7860225b27a0|927b17e10d2112270ac30c4566238950baba4b7b|Already
> in *FrocksDB-8.10.0*|
> |[[FLINK-30457] Add periodic_compaction_seconds option to
> RocksJava|https://github.com/ververica/frocksdb/commit/ebed4b1326ca4c5c684b46813bdcb1164a669da1]|ebed4b1326ca4c5c684b46813bdcb1164a669da1|#8579|Already
> in *FrocksDB-8.10.0*|
> |[[hotfix] Add docs of how to upload ppc64le artifacts to
> s3|https://github.com/ververica/frocksdb/commit/de2ffe6ef0a11f856b89fb69a34bcdb4782130eb]|de2ffe6ef0a11f856b89fb69a34bcdb4782130eb|174639cf1e6080a8f8f37aec132b3a500428f913|Already
> in *FrocksDB-8.10.0*|
> |[[FLINK-33811] Fix the broken
> CI|https://github.com/ververica/frocksdb/commit/e605685600658f6b146e60c6f0c9543b63f78975]|e605685600658f6b146e60c6f0c9543b63f78975|
> |Fix in FLINK-35577|
> |[[FLINK-33811] Disable warning as
> error|https://github.com/ververica/frocksdb/commit/251e7fc45edc1d0f0e2e124232064f67388797c9]|251e7fc45edc1d0f0e2e124232064f67388797c9|
> |Fix in FLINK-35577|
> |+[[FLINK-23346] Avoid core dump when rethrowing the
> exception|https://github.com/ververica/frocksdb/commit/030daed4a99132aba57eed1a65ca8d42fbe0c8f0]+|030daed4a99132aba57eed1a65ca8d42fbe0c8f0|
> |Fix in FLINK-35574|
> **
> We support the API related to ingest DB in FRocksDb-8.10.0, but many of the
> fixes related to ingest DB were only integrated in the latest RocksDB
> version. So we need to add these fixed commit cherryclicks to FRocksDB.
> Mainly include:
> |*RocksDB Main Branch*|*Commit ID in FrocksDB-8.10.0*|*Plan*|
> |https://github.com/facebook/rocksdb/pull/11646|44f0ff31c21164685a6cd25a2beb944767c39e46|
> |
> |[https://github.com/facebook/rocksdb/pull/11868]|8e1adab5cecad129131a4eceabe645b9442acb9c|
> |
> |https://github.com/facebook/rocksdb/pull/11811|3c27f56d0b7e359defbc25bf90061214c889f40b|
> |
> |https://github.com/facebook/rocksdb/pull/11381|4d72f48e57cb0a95b67ff82c6e971f826750334e|
> |
> |https://github.com/facebook/rocksdb/pull/11379|8d8eb0e77e13a3902d23fbda742dc47aa7bc418f|
> |
> |https://github.com/facebook/rocksdb/pull/11378|fa878a01074fe039135e37720f669391d1663525|
> |
> |https://github.com/facebook/rocksdb/pull/12219|183d80d7dc4ce339ab1b6796661d5879b7a40d6a|
> |
> |https://github.com/facebook/rocksdb/pull/12328|ef430fc72407950f94ca2a4fbb2b15de7ae8ff4f|
> |
> |https://github.com/facebook/rocksdb/pull/12602| |Fix in
> https://issues.apache.org/jira/browse/FLINK-35576|
> {*}Summary{*}:
> The remaining changes required for FRocksDB are as follows
> * These are the FRocksDB related commitments that still need to be updated
> from 6.20.3 cherry pick to 8.10.0: （fix in FLINK-35574）
> ** +[[FLINK-23346] Avoid core dump when rethrowing the
> exception|https://github.com/ververica/frocksdb/commit/030daed4a99132aba57eed1a65ca8d42fbe0c8f0]+
> * FRocksDB will supports disabling perf context during compilation (fix in
> FLINK-35575）
> ** so that
> [[FLINK-19710]|https://github.com/ververica/frocksdb/commit/d6f50f33064f1d24480dfb3c586a7bd7a7dbac01]
> are not needed
> * Some FRocksDB CI related commits (fix in FLINK-35577)
> ** [[FLINK-33811] Fix the broken
> CI|https://github.com/ververica/frocksdb/commit/e605685600658f6b146e60c6f0c9543b63f78975]
> ** [Disable useless broken tests due to ci-image
> upgraded|https://github.com/ververica/frocksdb/commit/9fef987e988c53a33b7807b85a56305bd9dede81]
> ** +[Upgrade to Ubuntu 20.04 in our CircleCI
> config|https://github.com/ververica/frocksdb/commit/1fecfda040745fc508a0ea0bcbb98c970f89ee3e]+
> ** [[FLINK-33811] Disable warning as
> error|https://github.com/ververica/frocksdb/commit/251e7fc45edc1d0f0e2e124232064f67388797c9]
> * IngestDB related bugfix (fix in FLINK-35576)
> ** [https://github.com/facebook/rocksdb/pull/12602]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
