Myasuka commented on code in PR #25399:
URL: https://github.com/apache/flink/pull/25399#discussion_r1778080608
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTracker.java:
##########
@@ -434,6 +434,9 @@ private void setDurationSpanAttribute(
@VisibleForTesting
static final String LATEST_COMPLETED_CHECKPOINT_ID_METRIC =
"lastCompletedCheckpointId";
+ @VisibleForTesting
+ static final String LATEST_COMPLETED_CHECKPOINT_TIMESTAMP =
"lastCheckpointCompletedTimestamp";
Review Comment:
I think we should rename to `LATEST_CHECKPOINT_COMPLETED_TIMESTAMP`
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTracker.java:
##########
@@ -590,4 +596,16 @@ public Long getValue() {
}
}
}
+
+ private class LatestCompletedCheckpointTimestampGauge implements
Gauge<Long> {
Review Comment:
I think we should rename to `LatestCheckpointCompletedTimestampGauge`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
