RocMarshal commented on code in PR #140:
URL:
https://github.com/apache/flink-connector-jdbc/pull/140#discussion_r1792677288
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/util/VisibleForTest.java:
##########
@@ -0,0 +1,20 @@
+package org.apache.flink.connector.jdbc.core.util;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.lang.annotation.Documented;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Target;
+
+/**
+ * This annotations declares that a function, field, constructor, or entire
type, is only visible
+ * for testing purposes.
+ *
+ * <p>This annotation is typically attached when for example a method should
be {@code private}
+ * (because it is not intended to be called externally), but cannot be
declared private, because
+ * some tests need to have access to it.
+ */
+@Documented
+@Target({ElementType.TYPE, ElementType.METHOD, ElementType.FIELD,
ElementType.CONSTRUCTOR})
+@PublicEvolving
+public @interface VisibleForTest {}
Review Comment:
Maybe there’s no rush to modify anything before we reaching a conclusion.
I'm not familiar with the entire testing framework and the use of
annotations in Flink, so I couldn't make useful ideas.
If we decide to change the relevant annotations and utility classes to
`non-internal`, we should confirm what impact this will have on the main Flink
repository. If the impact is minimal, maybe we can initiate a discussion.
Hi, @MartijnVisser could you help give some ideas about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
