fapaul commented on code in PR #122:
URL:
https://github.com/apache/flink-connector-kafka/pull/122#discussion_r1794816105
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaChangelogTableITCase.java:
##########
@@ -65,7 +64,6 @@ public void testKafkaDebeziumChangelogSource() throws
Exception {
tableConf.set(
ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ALLOW_LATENCY,
Duration.ofSeconds(1));
tableConf.set(ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_SIZE, 5000L);
-
tableConf.set(OptimizerConfigOptions.TABLE_OPTIMIZER_AGG_PHASE_STRATEGY,
"TWO_PHASE");
Review Comment:
What was the intention behind this change?
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationTest.java:
##########
@@ -42,7 +42,7 @@
public class FlinkKafkaProducerMigrationTest extends KafkaMigrationTestBase {
@Parameterized.Parameters(name = "Migration Savepoint: {0}")
public static Collection<FlinkVersion> parameters() {
- return FlinkVersion.rangeOf(FlinkVersion.v1_8, FlinkVersion.v1_16);
Review Comment:
Why did start of the range change from `1.8` to `1.12`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
