echauchot commented on PR #29: URL: https://github.com/apache/flink-connector-cassandra/pull/29#issuecomment-2404602509
> @echauchot Thanks for the review. The major reason of removing WriteAheadSinkTestBase as the base class of CassandraConnectorITCase is WriteAheadSinkTestBase is no more accessible out side of the package "org.apache.flink.streaming.runtime.operators". > > Shall I remove the CassandraConnectorITCase to package namespace org.apache.flink.streaming.runtime.operators? no I don't think the cassandra test should be moved to a flink core namespace. It looks strange to me that the visibility of WriteAheadSinkTestBase was reduced as part of the migration to Junit 5, so I [commented](https://issues.apache.org/jira/browse/FLINK-25544?focusedCommentId=17888215&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17888215) in the ticket were the change was made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
