clmccart commented on PR #32: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/32#issuecomment-2411834348
> looks like the sink rewrite was completed in [FLINK-24298](https://issues.apache.org/jira/browse/FLINK-24298). will need to take a look at that and probably remove the sink changes from this PR the main reason we wrote a new sink implementation was because the previous implementation was deprecated. we didnt make any significant performance improvements so i went ahead and remove the sink rewrite from this PR. we can followup with changes to the sink implementation in a subsequent PR but no changes are pressing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
