[
https://issues.apache.org/jira/browse/FLINK-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725643#comment-15725643
]
ASF GitHub Bot commented on FLINK-5041:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2781#discussion_r91077409
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -994,4 +1008,82 @@ private static int
compareKeyGroupsForByteArrays(byte[] a, byte[] b, int len) {
public File getInstanceBasePath() {
return instanceBasePath;
}
+
+ /**
+ * For backwards compatibility, remove again later!
+ */
+ @Deprecated
+ private void
restoreOldSavepointKeyedState(Collection<KeyGroupsStateHandle> restoreState)
throws Exception {
+
+ if (restoreState.isEmpty()) {
+ return;
+ }
+
+ HashMap<String, RocksDBStateBackend.FinalFullyAsyncSnapshot>
namedStates =
+
InstantiationUtil.deserializeObject(restoreState.iterator().next().openInputStream(),
userCodeClassLoader);
+
+ DataInputView inputView =
namedStates.values().iterator().next().stateHandle.getState(userCodeClassLoader);
--- End diff --
Please add a safety check that the `namedStates` map has exactly one entry.
> Implement savepoint backwards compatibility 1.1 -> 1.2
> ------------------------------------------------------
>
> Key: FLINK-5041
> URL: https://issues.apache.org/jira/browse/FLINK-5041
> Project: Flink
> Issue Type: New Feature
> Components: State Backends, Checkpointing
> Affects Versions: 1.2.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
>
> This issue tracks the implementation of backwards compatibility between Flink
> 1.1 and 1.2 releases.
> This task subsumes:
> - Converting old savepoints to new savepoints, including a conversion of
> state handles to their new replacement.
> - Converting keyed state from old backend implementations to their new
> counterparts.
> - Converting operator and function state for all changed operators.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
