[
https://issues.apache.org/jira/browse/FLINK-5220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725759#comment-15725759
]
ASF GitHub Bot commented on FLINK-5220:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2923#discussion_r91084549
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/plan/rules/dataSet/PushProjectIntoBatchTableSourceScanITCase.scala
---
@@ -0,0 +1,370 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.table.plan.rules.dataSet
+
+import collection.JavaConversions._
+import org.apache.calcite.rel.{RelNode, RelVisitor}
+import org.apache.calcite.rel.core.TableScan
+import org.apache.flink.api.common.io.GenericInputFormat
+import org.apache.flink.api.common.typeinfo.{BasicTypeInfo,
TypeInformation}
+import org.apache.flink.api.java.table.BatchTableEnvironment
+import org.apache.flink.api.java.{DataSet, ExecutionEnvironment}
+import org.apache.flink.api.scala.batch.utils.TableProgramsTestBase
+import
org.apache.flink.api.scala.batch.utils.TableProgramsTestBase.TableConfigMode
+import org.apache.flink.api.table.{Row, TableEnvironment}
+import org.apache.flink.api.table.sources.{BatchTableSource,
ProjectableTableSource}
+import org.apache.flink.api.table.typeutils.RowTypeInfo
+import
org.apache.flink.test.util.MultipleProgramsTestBase.TestExecutionMode
+import org.junit.{Assert, Before, Ignore, Test}
+import org.junit.runner.RunWith
+import org.junit.runners.Parameterized
+
+import scala.collection.mutable
+
+/**
+ * Test push project down to batchTableSourceScan optimization
+ *
+ * @param mode
+ * @param configMode
+ */
+@RunWith(classOf[Parameterized])
+class PushProjectIntoBatchTableSourceScanITCase(mode: TestExecutionMode,
--- End diff --
These ITCases are very expensive and add significantly to the build time of
Flink. We try to have as few ITCases as possible.
Instead we have tests to check the optimized plan (see `TableTestBase`).
With these tests we check that the projection is properly pushed into the table
source for SQL and Table API.
In addition, we need two ITCases, one for DataSet and one for DataStream,
which check that the translation from `DataSetRel` (`DataStreamRel`) to
`DataSet` and `DataStream` is working correctly.
> Flink SQL projection pushdown
> -----------------------------
>
> Key: FLINK-5220
> URL: https://issues.apache.org/jira/browse/FLINK-5220
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: zhangjing
> Assignee: zhangjing
>
> The jira is to do projection pushdown optimization. Please go forward to the
> the design document for more details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
