[
https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726025#comment-15726025
]
ASF GitHub Bot commented on FLINK-3551:
---------------------------------------
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/2761#discussion_r91119867
--- Diff:
flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/SessionWindowing.scala
---
@@ -60,11 +64,9 @@ object SessionWindowing {
input.foreach(value => {
ctx.collectWithTimestamp(value, value._2)
ctx.emitWatermark(new Watermark(value._2 - 1))
- if (!fileOutput) {
- println(s"Collected: ${value}")
- }
+ if (!fileOutput) println(s"Collected: ${value}")
--- End diff --
AFAIK we encourage adding braces even for one line if statements, so the
previous version was better.
> Sync Scala and Java Streaming Examples
> --------------------------------------
>
> Key: FLINK-3551
> URL: https://issues.apache.org/jira/browse/FLINK-3551
> Project: Flink
> Issue Type: Sub-task
> Components: Examples
> Affects Versions: 1.0.0
> Reporter: Stephan Ewen
> Assignee: Lim Chee Hau
> Fix For: 1.0.1
>
>
> The Scala Examples lack behind the Java Examples
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
