snuyanzin commented on code in PR #33:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/33#discussion_r1820391930
##########
flink-connector-gcp-pubsub/src/main/java/org/apache/flink/connector/gcp/pubsub/sink/config/GcpPublisherConfig.java:
##########
@@ -52,7 +52,11 @@ public CredentialsProvider getCredentialsProvider() {
}
public TransportChannelProvider getTransportChannelProvider() {
- return transportChannelProvider.getTransportChannelProvider();
+ if (transportChannelProvider==null){
+ return null;
+ } else{
Review Comment:
```suggestion
if (transportChannelProvider == null){
return null;
} else {
```
is it able to compile locally? (`./mvnw clean verify`)
I guess it should fail with spotless complains
##########
flink-connector-gcp-pubsub/src/main/java/org/apache/flink/connector/gcp/pubsub/sink/config/GcpPublisherConfig.java:
##########
@@ -52,7 +52,11 @@ public CredentialsProvider getCredentialsProvider() {
}
public TransportChannelProvider getTransportChannelProvider() {
- return transportChannelProvider.getTransportChannelProvider();
+ if (transportChannelProvider==null){
+ return null;
+ } else{
Review Comment:
```suggestion
if (transportChannelProvider == null) {
return null;
} else {
```
is it able to compile locally? (`./mvnw clean verify`)
I guess it should fail with spotless complains
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
