[
https://issues.apache.org/jira/browse/FLINK-36245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893764#comment-17893764
]
Piotr Nowojski edited comment on FLINK-36245 at 10/29/24 10:39 AM:
-------------------------------------------------------------------
Hi [~kunni], [~renqs] and [~leonard]. I think this change has made the build
broken/unstable. Locally in the IntelliJ building Flink fails for me due to:
{code:java}
flink-apache/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/statemachine/KafkaEventsGeneratorJob.java:72:42
java: cannot access org.apache.flink.api.connector.sink2.StatefulSink
class file for org.apache.flink.api.connector.sink2.StatefulSink not found
{code}
flink-examples depend on flink-connector-kafka in version 3.0.0-17 that in
turns is still referring to the StatefulSink:
{code:java}
public class KafkaSink<IN> implements StatefulSink<IN, KafkaWriterState>,
TwoPhaseCommittingSink<IN, KafkaCommittable> (...)
{code}
Maven builds might be working due to some dumb luck.
https://issues.apache.org/jira/browse/FLINK-36621
was (Author: pnowojski):
Hi [~kunni], [~renqs] and [~leonard]. I think this change has made the build
broken/unstable. Locally in the IntelliJ building Flink fails for me due to:
{code:java}
flink-apache/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/statemachine/KafkaEventsGeneratorJob.java:72:42
java: cannot access org.apache.flink.api.connector.sink2.StatefulSink
class file for org.apache.flink.api.connector.sink2.StatefulSink not found
{code}
flink-examples depend on flink-connector-kafka in version 3.0.0-17 that in
turns is still referring to the StatefulSink:
{code:java}
public class KafkaSink<IN> implements StatefulSink<IN, KafkaWriterState>,
TwoPhaseCommittingSink<IN, KafkaCommittable> (...)
{code}
Maven builds might be working due to some dumb luck.
> Remove legacy SourceFunction / SinkFunction / Sink V1 API and deprecated
> method/interface in Sink V2 in 2.0
> -----------------------------------------------------------------------------------------------------------
>
> Key: FLINK-36245
> URL: https://issues.apache.org/jira/browse/FLINK-36245
> Project: Flink
> Issue Type: Technical Debt
> Components: Connectors / Common
> Reporter: Qingsheng Ren
> Assignee: LvYanquan
> Priority: Major
> Labels: 2.0-related, pull-request-available
> Fix For: 2.0-preview
>
>
> SourceFunction, SinkFunction and Sink V1 API has been marked as deprecated
> and should be removed in Flink 2.0.
> Considering SourceFunction / SinkFunction are heavily used in test cases for
> building a simple data generator or a data validator, it could be a huge
> amount of work to rewrite all these usages with Source and Sink V2 API. A
> viable path for 2.0-preview version would be:
> * Move SourceFunction, SinkFunction to an internal package, as a test util
> * Rewrite all Sink V1 implementations with Sink V2 directly (the usage of
> Sink V1 is low in the main repo)
> As a long term working item, all usages of SourceFunction and SinkFunction
> will be replaced by Source and Sink API.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
