Zakelly commented on code in PR #25587:
URL: https://github.com/apache/flink/pull/25587#discussion_r1821775190
##########
flink-test-utils-parent/flink-test-utils/src/test/java/org/apache/flink/state/benchmark/StateBackendBenchmarkUtils.java:
##########
@@ -280,10 +280,15 @@ public static <K, S extends State, T> void applyToAllKeys(
function);
}
- public static <K, S extends State, T> void compactState(
- RocksDBKeyedStateBackend<K> backend, StateDescriptor<S, T>
stateDescriptor)
+ public static <K, S extends State, T> boolean compactState(
Review Comment:
I'd suggest a javadoc describing the behavior.
##########
flink-test-utils-parent/flink-test-utils/src/test/java/org/apache/flink/state/benchmark/StateBackendBenchmarkUtils.java:
##########
@@ -280,10 +280,15 @@ public static <K, S extends State, T> void applyToAllKeys(
function);
}
- public static <K, S extends State, T> void compactState(
- RocksDBKeyedStateBackend<K> backend, StateDescriptor<S, T>
stateDescriptor)
+ public static <K, S extends State, T> boolean compactState(
+ KeyedStateBackend<K> backend, StateDescriptor<S, T>
stateDescriptor)
throws RocksDBException {
- backend.compactState(stateDescriptor);
+ if (!(backend instanceof RocksDBKeyedStateBackend)) {
+
Review Comment:
Redundant line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
