[ https://issues.apache.org/jira/browse/FLINK-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726114#comment-15726114 ]
ASF GitHub Bot commented on FLINK-4554: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2919#discussion_r91124734 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ArrayTypeTest.scala --- @@ -0,0 +1,342 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.table.expressions + +import java.sql.Date + +import org.apache.flink.api.common.typeinfo.{PrimitiveArrayTypeInfo, TypeInformation} +import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo +import org.apache.flink.api.scala.table._ +import org.apache.flink.api.table.expressions.utils.ExpressionTestBase +import org.apache.flink.api.table.typeutils.RowTypeInfo +import org.apache.flink.api.table.{Row, Types, ValidationException} +import org.junit.Test + +class ArrayTypeTest extends ExpressionTestBase { + + @Test(expected = classOf[ValidationException]) + def testEmptyArraySql(): Unit = { + testSqlApi("ARRAY[]", "FAIL") + } + + @Test(expected = classOf[ValidationException]) + def testEmptyArrayTableApi(): Unit = { + testTableApi("FAIL", "array()", "FAIL") + } + + @Test(expected = classOf[ValidationException]) + def testNullArraySql(): Unit = { + testSqlApi("ARRAY[NULL]", "FAIL") + } + + @Test(expected = classOf[ValidationException]) + def testDifferentTypesArraySql(): Unit = { + testSqlApi("ARRAY[1, TRUE]", "FAIL") + } + + @Test(expected = classOf[ValidationException]) + def testDifferentTypesArrayTableApi(): Unit = { + testTableApi("FAIL", "array(1, true)", "FAIL") + } + + @Test(expected = classOf[ValidationException]) + def testUnsupportedComparison(): Unit = { + testAllApis( + 'f2 <= 'f5.at(1), + "f2 <= f5.at(1)", + "f2 <= f5[1]", + "FAIL") + } + + @Test(expected = classOf[ValidationException]) + def testElementNonArray(): Unit = { --- End diff -- test other APIs as well? > Add support for array types > --------------------------- > > Key: FLINK-4554 > URL: https://issues.apache.org/jira/browse/FLINK-4554 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL > Reporter: Timo Walther > Assignee: Timo Walther > > Support creating arrays: > {code}ARRAY[1, 2, 3]{code} > Access array values: > {code}myArray[3]{code} > And operations like: > {{UNNEST, UNNEST WITH ORDINALITY, CARDINALITY}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)