robobario commented on code in PR #910:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/910#discussion_r1830340036
##########
.github/workflows/ci.yml:
##########
@@ -83,15 +83,33 @@ jobs:
flink-version: "v1_20"
http-client: ${{ matrix.http-client }}
test: test_application_operations.sh
+ java_rutimes:
Review Comment:
```suggestion
java_runtimes:
```
##########
.github/workflows/e2e.yaml:
##########
@@ -27,6 +27,9 @@ on:
create-namespace:
type: boolean
default: false
+ append-java-version:
Review Comment:
maybe this should be an optional `flink-java-version` and the matrix could
contain the versions we want to test
##########
.github/workflows/ci.yml:
##########
@@ -83,15 +83,33 @@ jobs:
flink-version: "v1_20"
http-client: ${{ matrix.http-client }}
test: test_application_operations.sh
+ java_rutimes:
+ name: Java runtimes smoke test
+ needs: e2e_smoke_test
+ strategy:
+ matrix:
+ http-client: [ "okhttp" ]
+ java-version: [ "11", "17"]
+ flink-version:
+ - "v1_20"
+ - "v1_19"
+ - "v1_18"
+ uses: ./.github/workflows/e2e.yaml
+ with:
+ java-version: ${{ matrix.java-version }}
Review Comment:
I'm wondering if it's a bit funky that we are using `java-version` to
control both the JDK/JRE used to build/run the operator and the runtime of the
flink image. Aren't they different dimensions of the matrix?
This would show that a JDK17 operator works with a JDK17 flink image, but
not cover the current default operator runtime with a JDK17 flink image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
