hlteoh37 opened a new pull request, #180:
URL: https://github.com/apache/flink-connector-aws/pull/180

   
   ## Purpose of the change
   
   Fix `NOTICE` files to reflect the dependencies packaged into the uber jar.
   
   ## Verifying this change
   Validated using helpful script provided by @dannycranmer 
   ```
   mvn clean install | grep Including | grep -v org.apache.flink | sed -E 
's/\S+\s+\S+\s+(\S+).*/\1/' | sed 's/:jar//' | sed 's/.*Including \(.*\) in the 
shaded jar\./\1/' | sort > /tmp/from.build
   cat src/main/resources/META-INF/NOTICE | grep "^\- " | sed 's/- //' | sort > 
/tmp/from.notice
   diff /tmp/from.build /tmp/from.notice
   ```
   
   ## Significant changes
   *(Please check any boxes [x] if the answer is "yes". You can first publish 
the PR and check them afterwards, for convenience.)*
   - [ ] Dependencies have been added or upgraded
   - [ ] Public API has been changed (Public API is any class annotated with 
`@Public(Evolving)`)
   - [ ] Serializers have been changed
   - [ ] New feature has been introduced
     - If yes, how is this documented? (not applicable / docs / JavaDocs / not 
documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to