[
https://issues.apache.org/jira/browse/FLINK-36495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897204#comment-17897204
]
Gantigmaa Selenge edited comment on FLINK-36495 at 11/11/24 4:45 PM:
---------------------------------------------------------------------
Removing getSchema() results in so many changes that are out of scope for this
Jira. In order to use the new
getUnresolvedSchema() method instead of getSchema(), a large number of util
classes, deprecated classes and test classes need to be switched to use Schema
instead of TableSchema. TableSchema itself is deprecated, but it is widely used
across several sub modules (flink-table-api-*, flink-table-common,
flink-table-plannner, pyflink, docs). TableSchema is not directly compatible
with Schema either, in some cases, it needs to be replaced with ResolvedSchema.
There are also deprecated classes such as CatalogTableImpl, CsvTableSink,
CsvTableSource etc. that use TableSchema. It doesn't seem to make sense to put
an effort in updating them since they are deprecated. So they need to be
removed first.
I think before we can progress with this Jira, we need to first remove the
deprecated TableSchema and the other deprecated classes that use TableSchema.
[~xuyangzhong] Please let me know what you think. If you agree, I can create a
separate Jira for removing TableSchema and the other ones.
was (Author: JIRAUSER298404):
Removing getSchema() results in so many changes that are out of scope for this
Jira. In order to use the new
getUnresolvedSchema() method instead of getSchema(), a large number of util
classes, deprecated classes and test classes need to be switched to use Schema
instead of TableSchema. TableSchema itself is deprecated, but it is widely used
across several sub modules (flink-table-api-*, flink-table-common,
flink-table-plannner, pyflink, docs). TableSchema is not directly compatible
with Schema either, in some cases, it needs to be replaced with ResolvedSchema
but sometimes it is not available to the classes.
There are also deprecated classes such as CatalogTableImpl, CsvTableSink,
CsvTableSource etc. that use TableSchema. It doesn't seem to make sense to put
an effort in updating them since they are deprecated. So they need to be
removed first.
I think before we can progress with this Jira, we need to first remove the
deprecated TableSchema and the other deprecated classes that use TableSchema.
[~xuyangzhong] Please let me know what you think. If you agree, I can create a
separate Jira for removing TableSchema and the other ones.
> Remove deprecated method `CatalogBaseTable#getSchema`
> -----------------------------------------------------
>
> Key: FLINK-36495
> URL: https://issues.apache.org/jira/browse/FLINK-36495
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
> Reporter: xuyang
> Priority: Major
> Fix For: 2.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
