jnh5y commented on code in PR #25206:
URL: https://github.com/apache/flink/pull/25206#discussion_r1840738408
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecRank.java:
##########
@@ -37,20 +39,48 @@
import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
import org.apache.flink.table.types.logical.RowType;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
import java.util.Collections;
+import java.util.List;
+
+import static
org.apache.flink.table.planner.plan.nodes.exec.stream.StreamExecRank.FIELD_NAME_OUTPUT_RANK_NUMBER;
/**
* {@link BatchExecNode} for Rank.
*
* <p>This node supports two-stage(local and global) rank to reduce
data-shuffling.
*/
+@ExecNodeMetadata(
+ name = "batch-exec-rank",
Review Comment:
Ah, good catch. The optimizations for rank are different in streaming and
batch. I'll go looking for a case which is optimized in batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
