rkhachatryan commented on code in PR #25652:
URL: https://github.com/apache/flink/pull/25652#discussion_r1841143668
##########
flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java:
##########
@@ -149,9 +149,7 @@ void testJobIDLogging(@InjectClusterClient ClusterClient<?>
clusterClient) throw
sourceCoordinatorLogging,
asList(
"Starting split enumerator.*",
- "Distributing maxAllowedWatermark.*",
- "Source .* registering reader for parallel task.*",
- "Closing SourceCoordinator for source .*"));
Review Comment:
Per my understanding,
`Distributing maxAllowedWatermark` might not be logged if
a) announcement happens after 2 checkpoints
b) watermark is not reported before 2 checkpoints
`Closing SourceCoordinator for source` might not be captured because IIRC,
job cancellation does not wait for `JobMaster` shutdown and cleanup.
`Source .* registering reader for parallel task` is still there (just a diff
view artifact I guess)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
