mxm commented on code in PR #911: URL: https://github.com/apache/flink-kubernetes-operator/pull/911#discussion_r1843399317
########## helm/flink-kubernetes-operator/conf/log4j-operator.properties: ########## @@ -32,3 +32,5 @@ logger.conf.level = WARN # Avoid logging fallback key INFO messages logger.conf.name = org.apache.flink.configuration.Configuration logger.conf.level = WARN + +monitorInterval = 30 Review Comment: I think we should disable automatic reloading by default. ########## helm/flink-kubernetes-operator/conf/log4j-console.properties: ########## @@ -60,3 +60,5 @@ appender.rolling.strategy.max = 10 # Suppress the irrelevant (wrong) warnings from the Netty channel handler logger.netty.name = org.apache.flink.shaded.akka.org.jboss.netty.channel.DefaultChannelPipeline logger.netty.level = OFF + +monitorInterval = 30 Review Comment: What's the interval? Seconds? Can we add this in a comment which also explains what this does? ########## helm/flink-kubernetes-operator/conf/log4j-operator.properties: ########## @@ -32,3 +32,5 @@ logger.conf.level = WARN # Avoid logging fallback key INFO messages logger.conf.name = org.apache.flink.configuration.Configuration logger.conf.level = WARN + +monitorInterval = 30 Review Comment: What's the interval? Seconds? Can we add this in a comment which also explains what this does? ########## helm/flink-kubernetes-operator/conf/log4j-console.properties: ########## @@ -60,3 +60,5 @@ appender.rolling.strategy.max = 10 # Suppress the irrelevant (wrong) warnings from the Netty channel handler logger.netty.name = org.apache.flink.shaded.akka.org.jboss.netty.channel.DefaultChannelPipeline logger.netty.level = OFF + +monitorInterval = 30 Review Comment: I think we should disable automatic reloading by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
