snuyanzin commented on code in PR #25665:
URL: https://github.com/apache/flink/pull/25665#discussion_r1846638198
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinition.java:
##########
@@ -292,11 +293,18 @@ public Builder kind(FunctionKind kind) {
return this;
}
+ public Builder staticArguments(StaticArgument... staticArguments) {
+ this.typeInferenceBuilder.staticArguments(staticArguments);
+ return this;
+ }
+
+ /** @deprecated Use {@link #staticArguments(StaticArgument...)}
instead. */
Review Comment:
Shouldn't we add `@Deprecated` annotation as well?
At least this is what javadoc for `@Deprecated` says
>The @Deprecated annotation should always be present if the @deprecated
javadoc tag is present, and vice-versa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
