noorall commented on code in PR #25414:
URL: https://github.com/apache/flink/pull/25414#discussion_r1846478063
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/forwardgroup/ForwardGroupComputeUtilTest.java:
##########
@@ -59,6 +68,28 @@ void testIsolatedVertices() throws Exception {
checkGroupSize(groups, 0);
}
+ @Test
+ void testIsolatedChainedStreamNodeGroups() throws Exception {
+ Map<StreamNode, List<StreamNode>>
topologicallySortedChainedStreamNodeByStartNode =
+ new LinkedHashMap<>();
+ Map<StreamNode, Set<StreamNode>> forwardProducersByStartNode =
Collections.emptyMap();
+ for (int i = 1; i <= 3; ++i) {
+ StreamNode streamNode = createStreamNode(i);
+ topologicallySortedChainedStreamNodeByStartNode.put(
+ streamNode, Collections.singletonList(streamNode));
+ }
+
+ Set<ForwardGroup> groups =
+ computeForwardGroups(
+ topologicallySortedChainedStreamNodeByStartNode,
+ forwardProducersByStartNode);
+
+ // Different from the job vertex forward group, the stream node
forward group is allowed to
+ // contain only one single stream node, as these groups may merge with
other groups in the
+ // future.
+ checkGroupSize(groups, 3, 1);
Review Comment:
> B.T.W. will it create a job vertex forward group if the size is 1 when the
job vertex is created?
No, it won’t. A forward group containing only one job vertex is meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
