huyuanfeng2018 commented on code in PR #25504:
URL: https://github.com/apache/flink/pull/25504#discussion_r1848081364
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/AbstractSlotSharingStrategy.java:
##########
@@ -95,15 +96,15 @@ public void notifySchedulingTopologyUpdated(
* topologically sorted.
*/
@Nonnull
- static LinkedHashMap<JobVertexID, List<SchedulingExecutionVertex>>
getExecutionVertices(
- SchedulingTopology topology) {
- final LinkedHashMap<JobVertexID, List<SchedulingExecutionVertex>>
vertices =
- new LinkedHashMap<>();
+ static <T> LinkedHashMap<JobVertexID, List<T>> getExecutionVertices(
Review Comment:
Introducing a function parameter makes it difficult to read. Can add params
comments for easier reading?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
