yuxiqian commented on PR #3742: URL: https://github.com/apache/flink-cdc/pull/3742#issuecomment-2487833115
Most changes are just repetitive while some needs more attention: * Created wrapper classes `AbstractTestBaseProxy` because Flink's original version was targeted to JUnit 4 * Created `ExternalResourceProxy` and `StaticExternalResourceProxy` to use JUnit 4 style `@Rule`s and `@ClassRule`s as JUnit 5 Extensions * Modified `checkstyle.xml` to forbid using any other testing / asserting frameworks (copied from https://github.com/apache/iceberg/blob/main/.baseline/checkstyle/checkstyle.xml) cc @GOODBOY008 @whhe @ruanhang1993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
