liuml07 commented on code in PR #136:
URL:
https://github.com/apache/flink-connector-kafka/pull/136#discussion_r1855013412
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilderTest.java:
##########
@@ -217,6 +217,29 @@ public void testSettingInvalidCustomDeserializers(
.hasMessageContaining(expectedError);
}
+ @Test
+ public void testDefaultPartitionDiscovery() {
+ final KafkaSource<String> kafkaSource = getBasicBuilder().build();
+ // Commit on checkpoint and auto commit should be disabled because
group.id is not specified
+ assertThat(
+ kafkaSource
+ .getConfiguration()
+
.get(KafkaSourceOptions.PARTITION_DISCOVERY_INTERVAL_MS))
+
.isEqualTo(KafkaSourceOptions.PARTITION_DISCOVERY_INTERVAL_MS.defaultValue());
+ }
+
+ @Test
+ public void testPeriodPartitionDiscovery() {
Review Comment:
This newly added test is to avoid regressions for bounded source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
