ruanhang1993 commented on code in PR #3753:
URL: https://github.com/apache/flink-cdc/pull/3753#discussion_r1855717508
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformOperator.java:
##########
@@ -539,6 +541,10 @@ private void initializeUdf() {
// into UserDefinedFunction interface, thus the
provided UDF classes
// might not be compatible with the interface
definition in CDC common.
Object udfInstance =
udfFunctionInstances.get(udf.getName());
+ if (udfInstance instanceof BuiltInModel) {
+ ((BuiltInModel) udfInstance)
+
.configure(Configuration.fromMap(udf.getParameters()));
Review Comment:
Supporting configuration is also a feature for udf. The method `configure`
should be in the interface `UserDefinedFunction` instead of `BuiltInModel`.
In other words, why does `BuiltInModel` need the method `configure` and
`UDF` does not need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
