XComp commented on code in PR #25553:
URL: https://github.com/apache/flink/pull/25553#discussion_r1856018587
##########
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java:
##########
@@ -507,7 +507,7 @@ protected CompletableFuture<Void>
stopClusterServices(boolean cleanupHaData) {
}
}
- if (executionGraphInfoStore != null) {
+ if (executionGraphInfoStore != null &&
!executionGraphInfoStore.isClosed()) {
Review Comment:
Thanks for working on this issue, @eaugene . I feel, we don't need the
`isClosed` method to solve the issue. What about unsetting
`executionGraphInfoStore` after closing it successfully, instead? That would
reduce the size of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
