fsk119 commented on code in PR #25705:
URL: https://github.com/apache/flink/pull/25705#discussion_r1865188870
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/util/SqlGatewayRestAPIVersion.java:
##########
@@ -51,7 +51,10 @@ public enum SqlGatewayRestAPIVersion
V2(false, true),
// V3 introduces materialized table related APIs
- V3(true, true);
+ V3(false, true),
+
+ // V4 supports to deploy script to application cluster
+ V4(true, true);
Review Comment:
AFAIK, Hive[1] or Livy[2] support to bump its version when adding a new
method. I think it brings following benefits:
* It make users more easy to use the gateway. Users knows the differences
among different vesion. They don't need to read the Flink release notes to
understand the differences.
* It reduces the ease that developers understand what is incompatible? Every
REST API change should be used to bump the version.
[1]
https://github.com/apache/hive/blob/master/service-rpc/if/TCLIService.thrift#L40
[2]
https://github.com/apache/incubator-livy/blob/1f6bd7ab55db3e5b08ff133d554b32db83a23890/server/src/main/scala/org/apache/livy/server/ApiVersions.scala#L24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
