becketqin commented on code in PR #25569:
URL: https://github.com/apache/flink/pull/25569#discussion_r1866671173
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -100,6 +102,50 @@ void testCloseCleansUpPreviouslyClosedFetcher() throws
Exception {
fetcherManager.close(Long.MAX_VALUE);
}
+ /**
Review Comment:
It might be better to keep this comment here. In general, the tests should
be testing against the behavior. But in this particular case, the test is
against the implementation. Keeping the comment helps the maintainers know that
this test can actually be removed if the implementation changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
