[
https://issues.apache.org/jira/browse/FLINK-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733003#comment-15733003
]
ASF GitHub Bot commented on FLINK-5298:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2974
[FLINK-5298] TM checks that log file exists
This PR slightly modifies the `TaskManager#handleRequestTaskManagerLog`.
For one it verifies that the log file actually exists before opening it.
Second, if the logFilePathOption is empty it no longer throws an IOException
(which _could_ crash the TM) but instead forwards it to the sender.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 5298_tm_log
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2974.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2974
----
commit c135d1940e61a4a80b274042e6e095f3369ec911
Author: zentol <ches...@apache.org>
Date: 2016-12-08T18:28:12Z
[FLINK-5298] TM checks that log file exists
----
> TaskManager crashes when TM log not existant
> --------------------------------------------
>
> Key: FLINK-5298
> URL: https://issues.apache.org/jira/browse/FLINK-5298
> Project: Flink
> Issue Type: Bug
> Components: TaskManager, Webfrontend
> Affects Versions: 1.1.0, 1.2.0
> Reporter: Mischa Krüger
> Assignee: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.2.0
>
>
> {code}
> java.io.FileNotFoundException: flink-taskmanager.out (No such file or
> directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.<init>(FileInputStream.java:138)
> at
> org.apache.flink.runtime.taskmanager.TaskManager.org$apache$flink$runtime$taskmanager$TaskManager$$handleRequestTaskManagerLog(TaskManager.scala:833)
> at
> org.apache.flink.runtime.taskmanager.TaskManager$$anonfun$handleMessage$1.applyOrElse(TaskManager.scala:340)
> at
> scala.runtime.AbstractPartialFunction$mcVL$sp.apply$mcVL$sp(AbstractPartialFunction.scala:33)
> at
> scala.runtime.AbstractPartialFunction$mcVL$sp.apply(AbstractPartialFunction.scala:33)
> at
> scala.runtime.AbstractPartialFunction$mcVL$sp.apply(AbstractPartialFunction.scala:25)
> at
> org.apache.flink.runtime.LeaderSessionMessageFilter$$anonfun$receive$1.applyOrElse(LeaderSessionMessageFilter.scala:44)
> at
> scala.runtime.AbstractPartialFunction$mcVL$sp.apply$mcVL$sp(AbstractPartialFunction.scala:33)
> at
> scala.runtime.AbstractPartialFunction$mcVL$sp.apply(AbstractPartialFunction.scala:33)
> at
> scala.runtime.AbstractPartialFunction$mcVL$sp.apply(AbstractPartialFunction.scala:25)
> at
> org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:33)
> at
> org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:28)
> at scala.PartialFunction$class.applyOrElse(PartialFunction.scala:118)
> at
> org.apache.flink.runtime.LogMessages$$anon$1.applyOrElse(LogMessages.scala:28)
> at akka.actor.Actor$class.aroundReceive(Actor.scala:465)
> at
> org.apache.flink.runtime.taskmanager.TaskManager.aroundReceive(TaskManager.scala:122)
> at akka.actor.ActorCell.receiveMessage(ActorCell.scala:516)
> at akka.actor.ActorCell.invoke(ActorCell.scala:487)
> at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:254)
> at akka.dispatch.Mailbox.run(Mailbox.scala:221)
> at akka.dispatch.Mailbox.exec(Mailbox.scala:231)
> at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
> at
> scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
> at
> scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
> at
> scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
> 2016-12-08 16:45:14,995 INFO
> org.apache.flink.mesos.runtime.clusterframework.MesosTaskManager - Stopping
> TaskManager akka://flink/user/taskmanager#1361882659.
> 2016-12-08 16:45:14,995 INFO
> org.apache.flink.mesos.runtime.clusterframework.MesosTaskManager -
> Disassociating from JobManager
> 2016-12-08 16:45:14,997 INFO org.apache.flink.runtime.blob.BlobCache
> - Shutting down BlobCache
> 2016-12-08 16:45:15,006 INFO
> org.apache.flink.runtime.io.disk.iomanager.IOManager - I/O manager
> removed spill file directory
> /tmp/flink-io-e61f717b-630c-4a2a-b3e3-62ccb40aa2f9
> 2016-12-08 16:45:15,006 INFO
> org.apache.flink.runtime.io.network.NetworkEnvironment - Shutting down
> the network environment and its components.
> 2016-12-08 16:45:15,008 INFO
> org.apache.flink.runtime.io.network.netty.NettyClient - Successful
> shutdown (took 1 ms).
> 2016-12-08 16:45:15,009 INFO
> org.apache.flink.runtime.io.network.netty.NettyServer - Successful
> shutdown (took 0 ms).
> 2016-12-08 16:45:15,020 INFO
> org.apache.flink.mesos.runtime.clusterframework.MesosTaskManager - Task
> manager akka://flink/user/taskmanager is completely shut down.
> 2016-12-08 16:45:15,023 ERROR
> org.apache.flink.runtime.taskmanager.TaskManager - Actor
> akka://flink/user/taskmanager#1361882659 terminated, stopping process...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
