Zakelly commented on code in PR #25745:
URL: https://github.com/apache/flink/pull/25745#discussion_r1872679104
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackend.java:
##########
@@ -227,6 +233,21 @@ public void setup(@Nonnull StateRequestHandler
stateRequestHandler) {
this.stateRequestHandler = stateRequestHandler;
}
+ @Override
+ public <N, S extends State, SV> S getOrCreateKeyedState(
Review Comment:
I'm not sure if we still need `createState` interface in case the
`getOrCreateKeyedState` is provided. How about make that `protected`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
