yuxiqian commented on code in PR #3765:
URL: https://github.com/apache/flink-cdc/pull/3765#discussion_r1872931587
##########
.dlc.json:
##########
@@ -10,7 +10,7 @@
"pattern": "^{"
},
{
- "pattern": "^https://repo1.maven.org/maven2/org/apache/flink.*SNAPSHOT.*";
+ "pattern": "^https://repo1.maven.org/maven2/org/apache/flink.*";
Review Comment:
Currently, CDC CI uses
[markdown-link-check](https://github.com/tcort/markdown-link-check) to validate
dead links and [Hugo project](https://gohugo.io) to generate static websites.
Interpolated URL links like
`https://repo1.maven.org/maven2/org/apache/flink/flink-sql-connector-db2-cdc/{{<
param Version >}}/flink-sql-connector-db2-cdc-{{< param Version >}}.jar` are
replaced to valid link when Hugo compiles it, but markdown-link-check doesn't
understand it and will trigger a false alarm.
I also agree that silencing all maven link checks isn't very ideal. Any
suggestions on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
