dyccode commented on code in PR #25711:
URL: https://github.com/apache/flink/pull/25711#discussion_r1873331285
##########
flink-formats/flink-orc/pom.xml:
##########
@@ -141,6 +149,34 @@ under the License.
<groupId>org.slf4j</groupId>
<artifactId>slf4j-reload4j</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>${protoc.version}</version>
+ <scope>provided</scope>
Review Comment:
> Is it correct that we're excluding it from the dependency, yet we expect
that it's a `provided` dependency? The Flink runtime doesn't offer this by
default, so why do we do it like this?
1.You are right, it my mistake. The Flink runtine should offer protobuf-java
by default. I will modify it later.
2.I am testing the program that uses ORC in Flink 1.20 whether upgrade to
Flink 2.0 normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
