gaborgsomogyi commented on code in PR #25757:
URL: https://github.com/apache/flink/pull/25757#discussion_r1874499916
##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java:
##########
@@ -2046,7 +2046,9 @@ private boolean isValidPojoField(Field f, Class<?> clazz,
List<Type> typeHierarc
}
// check for setters (<FieldName>_$eq for scala)
if ((methodNameLow.equals("set" + fieldNameLow)
- || methodNameLow.equals(fieldNameLow + "_$eq"))
+ || methodNameLow.equals(fieldNameLow + "_$eq")
+ || (fieldNameLow.startsWith("is")
+ && methodNameLow.equals("set" +
fieldNameLow.substring(2))))
Review Comment:
If that would be a one-liner then I would add that but it would completely
blow up the code.
* By default lombok generates `isHasAncestor` and `setHasAncestor` which is
just bad
* With `@Accessors(fluent = true)` there is no setter generated + the getter
has different signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
