fredia commented on code in PR #25760:
URL: https://github.com/apache/flink/pull/25760#discussion_r1875309207
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##########
@@ -291,13 +291,21 @@ public <IN, OUT> InternalStateFuture<OUT> handleRequest(
public <IN, OUT> OUT handleRequestSync(
State state, StateRequestType type, @Nullable IN payload) {
InternalStateFuture<OUT> stateFuture = handleRequest(state, type,
payload);
- while (!stateFuture.isDone()) {
- try {
- mailboxExecutor.yield();
- } catch (InterruptedException e) {
- LOG.warn("Error while waiting for state future to complete.",
e);
- throw new RuntimeException("Error while waiting for state
future to complete.", e);
+ triggerIfNeeded(true);
+ try {
+ while (!stateFuture.isDone()) {
+ if (!mailboxExecutor.tryYield()) {
+ // We force trigger the buffer if targetNum == 0 (for
draining) or the state
Review Comment:
nit: We force trigger the buffer if the state executor is not fully loaded.
```suggestion
We force trigger the buffer if the state executor is not
fully loaded.
```
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStDBMultiRawMergePutRequest.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.state.forst;
+
+import org.apache.flink.core.state.InternalStateFuture;
+
+import org.forstdb.RocksDB;
+import org.forstdb.RocksDBException;
+
+import java.io.IOException;
+import java.util.Collection;
+
+/**
+ * The Put access request for ForStDB.
+ *
+ * @param <K> The type of key in put access request.
+ * @param <N> The type of namespace in put access request.
+ * @param <V> The type of value in put access request.
+ */
+public class ForStDBMultiRawMergePutRequest<K, N, V> extends
ForStDBPutRequest<K, N, V> {
Review Comment:
How about extracting `isMerge` from `ForStDBPutRequest`, and combining
`isMerge` and `RawMerge` together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
