davidradl commented on code in PR #25779:
URL: https://github.com/apache/flink/pull/25779#discussion_r1878202421


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.java:
##########
@@ -149,12 +157,129 @@ void testResolvingProctimeOfCustomTableTableApi() throws 
Exception {
         testUtil.verifyExecPlan(table);
     }
 
+    @TestTemplate
+    void testTimeAttributeOfView() {
+        if (!streamingMode) {
+            // time attributes not supported in batch
+            return;

Review Comment:
   I realised this - so you think it is not worth testing the time attributes 
for non streaming to show that is fails nicely? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to