yuxiqian commented on code in PR #3758:
URL: https://github.com/apache/flink-cdc/pull/3758#discussion_r1879834646


##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/TransformFilterProcessor.java:
##########
@@ -135,6 +159,19 @@ private Object[] generateParams(BinaryRecordData record, 
long epochTime, String
                     params.add(opType);
                     continue;
             }
+
+            boolean foundInMeta = false;
+            for (SupportedMetadataColumn supportedMetadataColumn : 
supportedMetadataColumns) {
+                if (supportedMetadataColumn.getName().equals(columnName)) {
+                    params.add(supportedMetadataColumn.read(meta));
+                    foundInMeta = true;
+                    break;
+                }
+            }
+            if (foundInMeta) {
+                continue;
+            }

Review Comment:
   `UnmodifiableMap` could be an option. Of course building one dynamically is 
fine, too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to