davidradl commented on code in PR #25791:
URL: https://github.com/apache/flink/pull/25791#discussion_r1881885344
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/expressions/ExpressionSerializationTest.java:
##########
@@ -172,13 +172,13 @@ public static Stream<TestSpec> testData() {
.expectStr("POSITION(`f0` IN 'ABC')"),
TestSpec.forExpr($("f0").trim("ABC"))
.withField("f0", DataTypes.STRING())
- .expectStr("TRIM BOTH 'ABC' FROM `f0`"),
+ .expectStr("TRIM(BOTH 'ABC' FROM `f0`)"),
TestSpec.forExpr($("f0").trimLeading("ABC"))
.withField("f0", DataTypes.STRING())
- .expectStr("TRIM LEADING 'ABC' FROM `f0`"),
+ .expectStr("TRIM(LEADING 'ABC' FROM `f0`)"),
TestSpec.forExpr($("f0").trimTrailing("ABC"))
.withField("f0", DataTypes.STRING())
- .expectStr("TRIM TRAILING 'ABC' FROM `f0`"),
+ .expectStr("TRIM(TRAILING 'ABC' FROM `f0`)"),
TestSpec.forExpr($("f0").overlay("ABC", 2))
Review Comment:
I am looking at the docs
[https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/dev/table/functions/systemfunctions/](https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/dev/table/functions/systemfunctions/)
I see the syntax as `STRING1.trim(LEADING, STRING2)` and the like - I am not
seeing FROM syntax I see here. Or is this syntax part of the table planner
representation of this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
