davidradl commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1882238434
##########
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java:
##########
@@ -230,15 +240,17 @@ public RestClusterClient(
restClient,
clusterId,
waitStrategy,
- DefaultClientHighAvailabilityServicesFactory.INSTANCE);
+ DefaultClientHighAvailabilityServicesFactory.INSTANCE,
+ null);
}
private RestClusterClient(
Configuration configuration,
@Nullable RestClient restClient,
T clusterId,
WaitStrategy waitStrategy,
- ClientHighAvailabilityServicesFactory clientHAServicesFactory)
+ ClientHighAvailabilityServicesFactory clientHAServicesFactory,
+ EventLoopGroup group)
Review Comment:
should we tag with @nullable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
