[
https://issues.apache.org/jira/browse/FLINK-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735030#comment-15735030
]
Fabian Hueske commented on FLINK-5255:
--------------------------------------
I see. The {{LogicalCalc}} is hidden in the {{RelSubset}} which is a collection
of equivalent (sub-)plans. {{RelSubset.getOriginal}} returns only the original
plan which is {{LogicalProject}}.
Checking for {{LogicalCalc}} has the benefit, that chains of {{LogicalProject}}
are merged into a single {{LogicalCalc}}.
So we should iterate over all rels of a {{RelSubset}} to check if it is a
{{LogicalCalc}}.
If we want to include support for {{LogicalFilter}} (or {{LogicalCalc}} with
condition) we need to prepare the single row join to deal with empty
broadcasted data sets, i.e., it should not throw an NPE in that case.
> Improve single row check in DataSetSingleRowJoinRule
> ----------------------------------------------------
>
> Key: FLINK-5255
> URL: https://issues.apache.org/jira/browse/FLINK-5255
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Alexander Shoshin
>
> {{DataSetSingleRowJoinRule}} checks converts an arbitrary inner join (cross,
> theta, equi) where one input has exactly one row into a broadcast-map join.
> Currently, the condition to check for the single row is that the input of the
> join must be a global aggregation. The check fails if the input is a
> {{LogicalCalc}} followed by {{LogicalAggregate}}.
> Hence, the following query cannot be executed:
> {code}
> SELECT absum, x.a
> FROM x, (SELECT a.sum + b.sum AS absum FROM y)
> {code}
> The single row check should be extended to accept a {{LogicalCalc}} that has
> no condition {{(RexProgram.getCondition() == null)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
