JunRuiLee commented on code in PR #25551:
URL: https://github.com/apache/flink/pull/25551#discussion_r1881952020
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SsgNetworkMemoryCalculationUtils.java:
##########
@@ -190,15 +191,18 @@ static void getMaxInputChannelInfoForDynamicGraph(
IntermediateResultPartition resultPartition =
ejv.getGraph().getResultPartitionOrThrow((partitionGroup.getFirst()));
- IndexRange subpartitionIndexRange =
+
+ Map<IndexRange, IndexRange> consumedSubpartitionGroups =
vertex.getExecutionVertexInputInfo(
resultPartition.getIntermediateResult().getId())
- .getSubpartitionIndexRange();
+ .getConsumedSubpartitionGroups();
+
+ int inputChannelNums =
Review Comment:
I think this returned value does not represent the max channel number. For
example, Apache celeborn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
