hiliuxg commented on code in PR #25710:
URL: https://github.com/apache/flink/pull/25710#discussion_r1886067914
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/AbstractPrometheusReporter.java:
##########
@@ -104,7 +104,7 @@ public void notifyOfAddedMetric(
final String key = dimension.getKey();
dimensionKeys.add(
CHARACTER_FILTER.filterCharacters(key.substring(1,
key.length() - 1)));
-
dimensionValues.add(labelValueCharactersFilter.filterCharacters(dimension.getValue()));
+ dimensionValues.add(dimension.getValue());
Review Comment:
Hi, @davidradl
I have added a unit test. Could you please review the code again?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
