zhuanshenbsj1 commented on code in PR #25258:
URL: https://github.com/apache/flink/pull/25258#discussion_r1886265775
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java:
##########
@@ -226,6 +243,37 @@ public HiveCatalog(
}
public static HiveConf createHiveConf(
+ @Nullable String hiveConfDir,
+ @Nullable String hadoopConfDir,
+ @Nullable ReadableConfig flinkConfiguration) {
+ HiveConf hiveconf = initHiveConf(hiveConfDir, hadoopConfDir);
+ // add all configuration key with prefix 'flink.hive.hadoop.' and
'flink.hive.' in flink
+ // conf to hive conf
+ String hivePrefix = FLINK_HIVE_CONFIG_PREFIXES;
+ String hadoopPrefix = "hadoop.";
+ if (flinkConfiguration != null) {
+ for (String key : flinkConfiguration.toMap().keySet()) {
Review Comment:
> nit: use flinkConfiguration.toMap().entrySet()
Adjust as you say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
