davidradl commented on code in PR #25810:
URL: https://github.com/apache/flink/pull/25810#discussion_r1888448176
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -661,6 +673,18 @@ public boolean dropTemporaryView(String path) {
}
}
+ @Override
+ public boolean dropView(String path) {
+ UnresolvedIdentifier unresolvedIdentifier =
getParser().parseIdentifier(path);
+ ObjectIdentifier identifier =
catalogManager.qualifyIdentifier(unresolvedIdentifier);
+ try {
+ catalogManager.dropView(identifier, false);
+ return true;
+ } catch (ValidationException e) {
+ return false;
Review Comment:
I guess the before the fix, this exception would have bubbled up the table
API. After the fix it is gobbled. I am thinking we should log the exception
here, so we have an indication of what failed somewhere. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
