davidradl commented on code in PR #25799:
URL: https://github.com/apache/flink/pull/25799#discussion_r1890036561
##########
docs/content/docs/dev/datastream/fault-tolerance/serialization/third_party_serializers.md:
##########
@@ -45,8 +45,8 @@ You could also programmatically set it as follows:
Configuration config = new Configuration();
// register the class of the serializer as serializer for a type
-config.set(PipelineOptions.SERIALIZATION_CONFIG,
- "[org.example.MyCustomType: {type: kryo, kryo-type: registered, class:
org.example.MyCustomSerializer}]");
+config.set(PipelineOptions.SERIALIZATION_CONFIG,
+ List.of("org.example.MyCustomType: {type: kryo, kryo-type: registered,
class: org.example.MyCustomSerializer}"));
Review Comment:
I notice that the way it was is the way that you need to specify it in
Scala. For Java the code actually has an example of ```
config.set(
PipelineOptions.SERIALIZATION_CONFIG,
Collections.singletonList(
String.format(
"%s: {type: kryo, kryo-type: default, class:
%s}",
PackagedProgramUtilsPipelineTest.class.getName(),
userSerializerClassName)));
```
would it not be better to copy the existing code and use
"Collections.singletonList("
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
